[JENKINS-73835] Delete LockStepTest.deleteRunningBuildNewBuildClearsLock now that running builds may not be deleted#716
Merged
MarkEWaite merged 3 commits intojenkinsci:masterfrom Oct 15, 2024
Conversation
…dClearsLock now that running builds may not be deleted
…y covers WorkflowRun.doKill
MarkEWaite
approved these changes
Oct 15, 2024
Contributor
|
I've labeled it as |
Member
@MarkEWaite use |
Contributor
I've added the developer label to the list of labels in the repository and have labeled this pull request with developer. |
1 task
Member
You have? |
Contributor
|
thanks to all for contribution |
Contributor
Apparently missed that final click to change the label. Will fix the changelog now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JENKINS-73835, jenkinsci/jenkins#9810 (and specifically jenkinsci/jenkins#9810 (comment)). It is no longer possible to delete builds that are still running, so
LockStepTest.deleteRunningBuildNewBuildClearsLockfails against Jenkins 2.481+.I considered making the test perform a hard kill via
WorkflowRun.doKillbefore deleting the build, but hard kills are already covered by various tests in https://github.com/jenkinsci/lockable-resources-plugin/blob/f310d75b5595c93593b0b81767e549389c8fea06/src/test/java/org/jenkins/plugins/lockableresources/LockStepHardKillTest.java, so I am proposing to just delete the test instead.Testing done
I tried a few test changes against 2.481 before deciding to delete the test.
Proposed upgrade guidelines
N/A
Submitter checklist
@NoExternalUse. In case it is used by non java code theUsed by {@code <panel>.jelly}Javadocs are annotated.evalto ease the future introduction of Content Security Policy (CSP) directives (see documentation).Maintainer checklist
Before the changes are marked as
ready-for-merge:upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).